CMake: Try to use pkg-config for hidapi on macOS#141
Open
muellermartin wants to merge 1 commit intoNitrokey:masterfrom
Open
CMake: Try to use pkg-config for hidapi on macOS#141muellermartin wants to merge 1 commit intoNitrokey:masterfrom
muellermartin wants to merge 1 commit intoNitrokey:masterfrom
Conversation
Member
|
Hi! |
Contributor
Author
|
As mentioned in the related issue, the build currently works for me (compiles and |
Member
|
I see. Which version of the homebrew package of |
Contributor
Author
As stated in the related issue, I'm using stable 0.8.0-rc1 (currently the latest version). |
szszszsz
approved these changes
Jun 15, 2020
Member
szszszsz
left a comment
There was a problem hiding this comment.
LGTM
Will be merged after brief tests / rebase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to use CMake's module for
pkg-configto find an installed version of HIDAPI and fall back to the current solution (local copy of HIDAPI in the source tree).This fixes #140.