Rickardraysearch/linebased tcp#38
Open
rickardraysearch wants to merge 40 commits intoNiryoRobotics:masterfrom
Open
Rickardraysearch/linebased tcp#38rickardraysearch wants to merge 40 commits intoNiryoRobotics:masterfrom
rickardraysearch wants to merge 40 commits intoNiryoRobotics:masterfrom
Conversation
…lient Fixing regexp for when niryo respond with a KO command response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #37 both the particular case and the larger problem with not having a resynchronization mechanism in the protocol.
This pull request builds on #36, and could replace it if the protocol change in here (see the changes to tcp_server.py ) is accepted.
One additional benefit to having a line-based protocol for the C# client is that the API available in .NET Standard 2.0 is sufficient to have a simple implementation, so this PR also relaxes the requirement on .NET versions, so that the client now works with both .NET Core and the legacy .NET Framework.