Repository navigation
Live scheduler: deliver a ready burst when the events end behind a busy consumer - #66
Open
MelbourneDeveloper wants to merge 1 commit into
Open
MelbourneDeveloper wants to merge 1 commit into
MelbourneDeveloper wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
The live scheduler again delivers a burst whose quiet window has elapsed when the events end while the consumer is still busy. The v0.11.0 release review against v0.10.1 found this regression and blocked the release on it.
Details
Step::Endedreturned without sending that burst.None.deliver_readyincrates/lspkit-server/src/live/scheduler.rssends a ready burst once a slot frees, then the task ends. If there is no ready burst, it returns at once. If the consumer has already gone, nothing is sent.How Do The Automated Tests Prove It Works?
live_scheduler.rs::events_ending_behind_a_busy_consumer_still_deliver_the_ready_burst:None.It failed before the fix (
the ready burst survives the end of the events) and passes after it.All 13
live_schedulertests and all 566 workspace tests pass.Locally, the coverage gate passes for
lspkit-serverandlspkit-server::live.lspkit(98.56%) andlspkit::sidecar(97.18%) miss their thresholds by the same amount on unchangedmainon this macOS machine.mainpasses them on CI.Spec / doc changes
None. The doc comments on
runanddeliver_readycite [MEM-LIFETIME-SCHEDULER-BACKLOG].Breaking changes
None.
🤖 Generated with Claude Code