Skip to content

Profiler: remaining discovery and memory-dashboard defects from production filming #4

Closed

Description

@MelbourneDeveloper

Profiler filming exposed these defects. Production progress reactivity, cross-platform source links and skill-directory links shipped in SharpLsp #341. Shared follow-up fixes merged in #3 (2242019).

  • Relative apphost launches: resolve executable and assembly paths against the target process's working directory. The real discovery test fails before the fix and passes afterward; the fixture now launches relatively throughout the engine E2E suite.
  • GC units: collection counts stay separate from runtime-named generation byte sizes through the model and dashboard. A real heap regression asserts five named regions and no fabricated counts.
  • Allocation sizes: long type names wrap so Size and Objects stay visible. Chromium rendering of a real heap capture reproduced the off-screen column at 480 pixels and verified the corrected layout.
  • Retention graph: still blurry on Retina screens with overlapping labels. Add device-pixel-ratio and layout regressions before fixing.

Validation: all 390 lspkit tests and coverage gates pass; upstream CI is green. SharpLsp's integration pin and live UI regression merged in Nimblesite/SharpLsp#346 after all 49 CI jobs and all four CodeQL analyses passed. The hosted profiler suites passed on Linux and Windows; all 294 local profiler tests passed on macOS.

Activity

  1. MelbourneDeveloper commented on Nov 20, 2026

    @MelbourneDeveloper
    CollaboratorAuthor

    Retention-graph defects fixed in PR #64; not yet released, so this stays open

    Seen in v0.10.1:

    • the retention graph renders blurry on HiDPI/Retina displays;
    • its node labels overlap.

    Fixed in PR #64:

    • packages/lsp-profiler-ui/src/canvas-hidpi.ts sizes the canvas backing store by devicePixelRatio.
    • ref-graph-layout.ts lays out labels in ordered layers that never collide.

    Also fixed in the same PR:

    • a failed memory/start now releases its session;
    • an ended CPU recording no longer blocks its PID;
    • CPU duration is measured from the sampler's start.

    Tests:

    • src/test/unit/ref-graph-layout.test.ts checks that no two label boxes overlap and that layers are ordered.
    • src/testing/webview-contract-memory.ts (retinaBackingStoreScalesByDevicePixelRatio) checks the canvas scaling.
    • memory_start_lifetime_tests.rs and session_lifetime_tests.rs cover the session fixes.
    • PR Fix #2, #4, #23, #42; memory-lifetime leaks and CPU session bugs #64 CI passed on 5a01304.

    Next: after #64 merges and ships in a release, I'll re-test the released lsp-profiler-ui package and close this issue with that evidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions