Skip to content

Cancellation regression can lose an earlier partial result #26

Closed

Description

@MelbourneDeveloper

A cancellation regression consumes an initial partial result before cancelling, then checks a collection containing only later results. Correct immediate cancellation can therefore fail the stream-history assertion. Retain the earlier receipt while preserving the standard cancellation response and the prohibition on late results.

Activity

  1. MelbourneDeveloper commented on Nov 17, 2026

    @MelbourneDeveloper
    CollaboratorAuthor

    Verified against the released v0.5.0 crates

    Method: git worktree at tag v0.5.0; replaced crates/lspkit/src, crates/lspkit-server/src and crates/lspkit-server/examples with the sources unpacked from the crates.io 0.5.0 downloads (sha256 lspkit fca7d7fa…f5ce7, lspkit-server 1472ab35…231f2). git status stayed clean: the published source is byte-identical to the tag. Rebuilt diagnostic-reference from it and ran the regression test:

    • lspkit-server 0.5.0: crates/lspkit-server/tests/cli_sessions/dispatcher.rs cancel_during_a_scan_stops_the_stream_with_the_standard_error → ok (1 passed, all 64 partials incl. the earlier one)

    Red→green evidence for the fix itself: docs/plans/issue-fix-evidence-21-26-48-49.md (PR #51).

  2. MelbourneDeveloper commented on Nov 20, 2026

    @MelbourneDeveloper
    CollaboratorAuthor

    ✅ Verified against the published v0.10.1 crates

    Artifact: the crates published on crates.io, lspkit = "=0.10.1" and lspkit-server = "=0.10.1". The scratch package has no path or git dependencies, and Cargo.lock gives source = "registry+https://github.com/rust-lang/crates.io-index" for both. The diagnostic-reference binary these tests drive is the one shipped inside the published lspkit-server-0.10.1.crate, copied from the unpacked tarball.

    Steps

    1. Create a scratch package depending only on the published crates.
    2. Copy the regression tests from the repo. Every assert*/expect/matches! line was diffed against the repo and is identical.
    3. cargo test --features pull

    Results: diagnostic_reference 7/7, sidecar_disconnect_session 2/2, uri 17/17, uri_authority 1/1, 0 failed. A control run against 0.5.0 fails as expected.

    This issue: the cancellation regressions in diagnostic_reference (cli_sessions/dispatcher.rs, 7/7) pass against the published example binary. The earlier partial result is kept in the stream history, the standard -32800 cancellation response is returned, and no late result is emitted after cancellation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions