You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Cancellation regression can lose an earlier partial result #26
A cancellation regression consumes an initial partial result before cancelling, then checks a collection containing only later results. Correct immediate cancellation can therefore fail the stream-history assertion. Retain the earlier receipt while preserving the standard cancellation response and the prohibition on late results.
Method: git worktree at tag v0.5.0; replaced crates/lspkit/src, crates/lspkit-server/src and crates/lspkit-server/examples with the sources unpacked from the crates.io 0.5.0 downloads (sha256 lspkit fca7d7fa…f5ce7, lspkit-server 1472ab35…231f2). git status stayed clean: the published source is byte-identical to the tag. Rebuilt diagnostic-reference from it and ran the regression test:
lspkit-server 0.5.0: crates/lspkit-server/tests/cli_sessions/dispatcher.rscancel_during_a_scan_stops_the_stream_with_the_standard_error → ok (1 passed, all 64 partials incl. the earlier one)
Red→green evidence for the fix itself: docs/plans/issue-fix-evidence-21-26-48-49.md (PR #51).
Artifact: the crates published on crates.io, lspkit = "=0.10.1" and lspkit-server = "=0.10.1". The scratch package has no path or git dependencies, and Cargo.lock gives source = "registry+https://github.com/rust-lang/crates.io-index" for both. The diagnostic-reference binary these tests drive is the one shipped inside the published lspkit-server-0.10.1.crate, copied from the unpacked tarball.
Steps
Create a scratch package depending only on the published crates.
Copy the regression tests from the repo. Every assert*/expect/matches! line was diffed against the repo and is identical.
cargo test --features pull
Results:diagnostic_reference 7/7, sidecar_disconnect_session 2/2, uri 17/17, uri_authority 1/1, 0 failed. A control run against 0.5.0 fails as expected.
This issue: the cancellation regressions in diagnostic_reference (cli_sessions/dispatcher.rs, 7/7) pass against the published example binary. The earlier partial result is kept in the stream history, the standard -32800 cancellation response is returned, and no late result is emitted after cancellation.
Activity
MelbourneDeveloper commentedon Nov 17, 2026
Verified against the released v0.5.0 crates
Method:
git worktreeat tagv0.5.0; replacedcrates/lspkit/src,crates/lspkit-server/srcandcrates/lspkit-server/exampleswith the sources unpacked from the crates.io 0.5.0 downloads (sha256 lspkitfca7d7fa…f5ce7, lspkit-server1472ab35…231f2).git statusstayed clean: the published source is byte-identical to the tag. Rebuiltdiagnostic-referencefrom it and ran the regression test:crates/lspkit-server/tests/cli_sessions/dispatcher.rscancel_during_a_scan_stops_the_stream_with_the_standard_error→ ok (1 passed, all 64 partials incl. the earlier one)Red→green evidence for the fix itself:
docs/plans/issue-fix-evidence-21-26-48-49.md(PR #51).Fix Windows URIs, sidecar truncation, cancellation results; add serve…
MelbourneDeveloper commentedon Nov 20, 2026
✅ Verified against the published v0.10.1 crates
Artifact: the crates published on crates.io,
lspkit = "=0.10.1"andlspkit-server = "=0.10.1". The scratch package has no path or git dependencies, andCargo.lockgivessource = "registry+https://github.com/rust-lang/crates.io-index"for both. Thediagnostic-referencebinary these tests drive is the one shipped inside the publishedlspkit-server-0.10.1.crate, copied from the unpacked tarball.Steps
assert*/expect/matches!line was diffed against the repo and is identical.cargo test --features pullResults:
diagnostic_reference7/7,sidecar_disconnect_session2/2,uri17/17,uri_authority1/1, 0 failed. A control run against 0.5.0 fails as expected.This issue: the cancellation regressions in
diagnostic_reference(cli_sessions/dispatcher.rs, 7/7) pass against the published example binary. The earlier partial result is kept in the stream history, the standard-32800cancellation response is returned, and no late result is emitted after cancellation.