Repository navigation
Workspace restore runs stale projects concurrently (bounded) (#563) - #618
Merged
Merged
Conversation
…K restores, reporting the first failure in project order without abandoning the rest (#563)
MelbourneDeveloper
enabled auto-merge (squash)
November 20, 2026 04:41
…d windows, not wall-clock time a loaded runner can stretch
…ng: a heap read before the loop starts has no Widgets, which a loaded runner exposed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the PERFORMANCE-PLAN [PERF-PROGRESSIVE-LOAD] item "restore projects concurrently (bounded)".
WorkspaceRestorerestores stale projects withParallel.ForEachAsync, at most 2–4 SDK restores at a time (each restore is its own MSBuild process).WorkspaceRestoreConcurrencyTestsuses real projects whose restore deliberately takes 6s. Two of them must finish in less than the 12s they take one after the other; both are restored exactly once, and a second open restores nothing. A failing project in the middle is the one named in the error, with NU1101, and the project after it is still restored.Both tests failed before the change: the projects ran in series (14.7s for three 4s restores), and the project after the failure was abandoned.