Repository navigation
Full-stack dead-code tests: default config, refresh on switch, cross-project C# and F# references - #616
Merged
Conversation
…the diagnostic refresh each monorepo switch sends; ticks the default-config and refresh rows
…rows the suites now prove
…ject uses is live and only the unused one is dead
…es is live in a monorepo; the dead-code e2e builds every project through one write_project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
More full-stack dead-code tests through the real host and both sidecars, covering the default configuration, the diagnostic refresh, and references from another project in C# and F#. Ticks the 10 static-analyzer plan rows they and the earlier suites prove.
Details
tests/e2e_modules/configuration_live.rs:csharp_unused_public_types_are_dead_only_in_a_monoreponow starts with NOsharplsp.toml, so the default config is what reports only the internal type. After each monorepo switch it waits for theworkspace/diagnostic/refreshthe server sends; that refresh is debounced, so it can arrive after the next pull already shows new results.a_public_csharp_type_another_project_uses_is_not_dead_in_a_monorepo(new): a two-project.slnxin whichAppusesLib.Used. OnlyOrphanis reported.a_public_fsharp_value_another_project_uses_is_not_dead_in_a_monorepo(new): the F# version. Onlyorphanis reported.write_project(root, name, ext, [properties, items], source)builds every C# and F# project in the file, replacing four copies of the same project-writing code.DIAGNOSTICS-STATIC-ANALYZERS-PLAN.md:How Do The Automated Tests Prove It Works?
cargo test --test lsp_e2e configuration_live: 4 passing against the real host and sidecars (2 new, 2 extended).assert_eq!on the name and severity set), so a referenced type or value showing up as dead fails the test.NOTICEDfor a refresh beyond those counted before the switch.cargo clippy --all-targetsandcargo fmtare clean.