Repository navigation
Dead-code rules link to their docs, full-stack C# dead-code test, and the plan rows existing suites prove - #615
Merged
Merged
Conversation
…lector, reference-count and F# full-stack rows the existing suites prove
…n the reusable workflows on JDK 21
…les carry the website's Diagnostics › Dead code section as codeDescription, from one shared RuleDocumentation constant
…n unused public type is dead only in a monorepo and an unused internal type always is; ticks the two C# full-stack rows
…ivate _build/_test/_clean-rider legs; lint-rider stays open pending a Kotlin linter decision
…with diff 9, npm audit clean
MelbourneDeveloper
enabled auto-merge (squash)
November 19, 2026 23:42
…RuleDocumentation's full name (IDE0002 in the repository's own diagnostics check)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
The dead-code rules
SLSPC0101andSLSPF0101now link to their documentation, a full-stack C# dead-code test is added, and 16 plan rows across four plans are ticked: 11 already proved by existing tests or a checked resolution, 5 by this PR.Details
SharpLsp.Sidecar.Common/RuleDocumentation.cs(new) is the one place for a SharpLsp rule's documentation URL. Both sidecars use it as the diagnostic'sHelpLink, which becomescodeDescription.href.SLSPC0101(C#) andSLSPF0101(F#) point at the website's new Diagnostics › Dead code section (id="dead-code"). Other SharpLsp rules keep no link.configuration_live.rscsharp_unused_public_types_are_dead_only_in_a_monoreporuns through the real host and C# sidecar.internaltype, as a warning.sharplsp.tomlalso reports the unusedpublictype, and both become errors.LiveSessionnow takes the rule code, so the existing F# test and this one share it._*-riderlegs, because the Makefile's twelve public targets are its whole surface.diff7 advisory is gone; the tree resolvesdiff9 andnpm auditreports 0 vulnerabilities.workspace.repository_kind. What shipped is[analyzers] dead_code/monorepo, and the ticked rows say so.lint-rider: no Kotlin linter is configured, andgradlew checkwould rerun the tests.How Do The Automated Tests Prove It Works?
FSharpAnalyzersTestsbuildDiagnostic maps a 1-based range… now also asserts thatSLSPF0101carries the dead-code docs link andSLSPF0102carries none.DeadCodeAnalyzerTests.NonMonorepo_reports_private_and_internal_dead_code_as_warningsasserts theSLSPC0101link.Actual: ""before the change. Now the F# suite passes 15/15 and the C# suite 6/6, with warnings as errors.configuration_live.rs: the new C# test and the existing F# test both pass (2/2) against the real host and sidecars._site/docs/diagnostics/index.htmlcarries<h2 id="dead-code">.cargo clippy --all-targets,cargo fmt --check,csharpier checkanddeslopare clean.