Repository navigation
Attach reliability test: a fresh process and its own session per attempt (Linux debug-inspection wedge) - #614
Merged
Conversation
…ime and pauses the session that attach started, instead of outliving the fixture's 30-second wait and pausing the previous attempt's ending session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
The 20-attach reliability test (added in #607) stops wedging Linux
debug-inspection. Each attempt now attaches to its own fresh process and pauses the session that attach started.Details
debug-inspection): attempt 2'sstopDebuggeetimed out after 45 s. The stuck session then failed every later suite in the chunk, 12 failures in all.pausewas ever sent.startAttachedreturnsvscode.debug.activeDebugSession, which still named attempt 1's ending session.pauseAttachedpolledthreadson that dead session until its 60-second limit.waitran out. The process exited (exitedcode 0 at +29 s), and the session never settled in time.DebugSessionRecorder, by its start index, never fromactiveDebugSession.How Do The Automated Tests Prove It Works?
debug-attach-reliability-e2e.test.tsat least 19 of 20 attaches pause a live process, and every detach leaves it running passes locally: 20/20 in 21 s, with every pause stop recorded and a clean session.debug-attach-e2e.test.tsstill passes (5 tests).debug-inspectionruns the test after the rest of the chunk, at CI speed.