Repository navigation
C# conversion-operator rename casts nested conversions instead of failing on overlapping edits - #608
Merged
Conversation
…e changes must not overlap' when one converted use is nested inside another (Twice(Pass(a)))
…ide the outer cast, built from the syntax tree, instead of emitting overlapping edits that fail the whole rename
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Renaming a C#
implicitconversion operator toexplicitno longer fails with "The changes must not overlap" when one converted use is nested inside another.Details
WorkspaceManager.Rename.Operators.csConversionCasts:Twice(Pass(a)), bothaandPass(a)convert through the operator. Their edits overlapped,SourceText.WithChangesthrew, and the whole rename failed with that raw exception.SyntaxNode.ReplaceNodes, so each inner conversion is already cast inside it:Twice((int)(Pass((int)(a)))).ConvertsThrough) and the cast spelling (CastText) are split into their own helpers.mainagainst v0.33.0. The bug is in code added since the release, so no issue was filed.How Do The Automated Tests Prove It Works?
WorkspaceManagerRenameConversionCastsTests.Implicit_to_explicit_casts_a_conversion_nested_in_a_converted_argument_without_overlapping_edits(new) uses a real project:explicit operator int;(int)a) stays one cast, never(int)(int);Twice((int)(Pass((int)(a)))).The changes must not overlap. (Parameter 'changes').WorkspaceManagerRenameOperatorsTestsstill pass unchanged: 4 tests covering binary, unary, refused respellings and explicit↔implicit casts.