feat: add harvest grace period to prevent reward behavior front-running#27
Open
fgimenez wants to merge 1 commit into
Open
feat: add harvest grace period to prevent reward behavior front-running#27fgimenez wants to merge 1 commit into
fgimenez wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: https://app.asana.com/1/1201208859446629/project/1213822431665320/task/1213823326175966
Adds a configurable grace period (default 1 minute, max 10 minutes) after
setMyRewardBehavior()during which permissionlessharvestRewards()is blocked. User-initiatedclaimRewards()remains unaffected. BatchharvestAllRewards()skips operators in the grace window without reverting. Owner can tune or disable (set to 0) viasetHarvestGracePeriod().Requires redeploying
NodeOperatorFactoryonly, existingNodeOperatorcontracts can be migrated viamigrateOperator().