[QA-94] add view-profile-on-web e2e test#23349
Open
emwrn wants to merge 2 commits into
Open
Conversation
Logs in as a free user, dismisses the dropdown that loginToNexus leaves open as part of its logged-in verification, stubs shell.openExternal in the main process, clicks the avatar to open the profile dropdown, clicks "View profile on web", and asserts the captured URL is a nexusmods.com /users/<id> page.
Aligns with the e2e best-practices doc: - Drop the per-test test.setTimeout override (GlobalTimeouts.TEST covers it). - Swap the avatar's 60s wait for Timeouts.NETWORK (userInfo round-trip). - Remove the explicit 10s override on the dropdown item; it's a pure UI element after a click and should use the default GlobalTimeouts.EXPECT.
Member
|
Needs a rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shell.openExternal.shell.openExternalin the Electron main process to capture URLs, then assert the captured URL matchesnexusmods.com/users/<id>.Implementation notes
loginToNexus's logged-in verification step clicks the avatar and leaves the dropdown open. The test dismisses it withEscapefirst, then drives its own open/click cycle so the assertions don't depend on the helper's side effects.Test plan
pnpm --filter @vortex/e2e exec playwright test view-profile-on-web.spec.tspasses (1.1m).pnpm run format:checkclean under WSL Linux oxfmt.pnpm run build.