[FIX] CardShredView 네비게이션 화면전환 적용 및 MainTabView 개선 - #44
Merged
Merged
Conversation
cchanmi
reviewed
Aug 31, 2026
Comment on lines
+77
to
+80
| try await DefaultAuthRepository( | ||
| networkManager: NetworkManager.shared, | ||
| tokenStorage: TokenStorage.shared | ||
| ).autoLogin() |
Collaborator
There was a problem hiding this comment.
p1
지금 현재 구조가 Core -> Data 구현제를 아는 구조인 것 같아요
NetworkManager가 DefaultAuthRepository를 직접 생성하고 있는데, 이미 기존 코드에서 DefaultAuthRepository가 NetworkManger로 요청을 보내는 반대 방향 의존도 있어서 결과적으로 Core -> Data -> Core 로 순환이 생기고 있는 것 같아요
NetworkManager에서 AuthRepository 프로토콜을 의존하고 구현체는 외부에서 주입받는 형태로 바꾸어도 좋을 것 같습니다
|
|
||
| // 재발급된 토큰은 HttpHeader가 요청을 다시 만들 때 Keychain에서 새로 읽어오므로, | ||
| // 원래 요청을 그대로 한 번 더 시도하면 된다. | ||
| return try await request(endpoint, responseType: responseType, isRetryAfterReissue: true) |
Collaborator
There was a problem hiding this comment.
p1
reissue 실패 → autoLogin 폴백 로직이 핵심 수정사항인 것 같은데 관련 테스트 코드가 있으면 좋을 것 같아요
성공/실패(missingFirebaseUser, firebaseSignInFailed) 케이스만이라도 커버되면 좋을 것 같고... 아니면 따로 검증할 방법 있을까요?
Collaborator
|
추가로 확인 필요한 부분이... 검색 화면에서 입력 텍스트필드에 텍스트 입력할 때 폰트 설정 필요해 보이네요 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe
CardShredView를 네비게이션 화면전환 적용했고 MainTabView에서 루트 NavigationStack을 관리할 수 있도록 수정했습니다.
Works made
Changes Made
As-Is
기존 로직
To-BE
동작 영상
https://github.com/user-attachments/assets/305641a5-c07f-45bb-b8c9-e55091d81a5b
How to Test
Issues Resolved
Additional context
References