Improve the order of message operation at _release_batch()#47
Open
kawasin73 wants to merge 1 commit into
Open
Conversation
timnd
suggested changes
Dec 11, 2019
timnd
left a comment
timnd
left a comment
Contributor
There was a problem hiding this comment.
Thanks, looks like a good improvement.
Comment on lines
+302
to
+306
| if messages_to_be_deleted: | ||
| # Note: This includes failed tasks. | ||
| self._consumer.delete_messages(messages_to_be_deleted, | ||
| self._batch_queue.name) | ||
|
|
Contributor
There was a problem hiding this comment.
Move this block before the comment block above.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to avoid message lost, you should enqueue messages to Dead Letter Queue before deleting messages in case of sudden death of worker process.
I think it is better to
release_messages()soon after checkingRESET_TIMEOUT_THRESHOLDbecausedelete_messages()may take some time.