Branding#16
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
|
||
| function buildDevUrl(port, slug, entryUrl) { | ||
| return `http://localhost:${port}/${slug}/${normalizeEntryUrl(entryUrl)}`; | ||
| return `http://localhost:${port}/${slug}/${normalizeEntryUrl(entryUrl)}?debugger=true`; |
There was a problem hiding this comment.
WARNING: If entry_url contains a query string (e.g., "presell?utm_source=google"), the resulting URL will be malformed with two ? characters: /slug/presell?utm_source=google?debugger=true. The normalizeEntryUrl function (line 19-23) does not strip or handle existing query parameters from entry_url.
Consider either:
- Stripping query params from
entry_urlinnormalizeEntryUrl(e.g.,.split('?')[0]) - Using proper URL construction that combines query params correctly (e.g.,
URLSearchParams) - Validating/ Documenting that
entry_urlmust not contain query params
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Overview
Previous issue resolved: The query string collision in Files Reviewed (2 files)
Reviewed by minimax-m2.7 · 110,792 tokens |
No description provided.