Skip to content

Branding#16

Merged
alexphelps merged 3 commits into
mainfrom
branding
May 8, 2026
Merged

Branding#16
alexphelps merged 3 commits into
mainfrom
branding

Conversation

@alexphelps
Copy link
Copy Markdown
Member

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 8, 2026

Codecov Report

❌ Patch coverage is 90.32258% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
lib/logger.js 90.00% 3 Missing ⚠️

📢 Thoughts on this report? Let us know!

Comment thread lib/actions/dev.js Outdated

function buildDevUrl(port, slug, entryUrl) {
return `http://localhost:${port}/${slug}/${normalizeEntryUrl(entryUrl)}`;
return `http://localhost:${port}/${slug}/${normalizeEntryUrl(entryUrl)}?debugger=true`;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: If entry_url contains a query string (e.g., "presell?utm_source=google"), the resulting URL will be malformed with two ? characters: /slug/presell?utm_source=google?debugger=true. The normalizeEntryUrl function (line 19-23) does not strip or handle existing query parameters from entry_url.

Consider either:

  1. Stripping query params from entry_url in normalizeEntryUrl (e.g., .split('?')[0])
  2. Using proper URL construction that combines query params correctly (e.g., URLSearchParams)
  3. Validating/ Documenting that entry_url must not contain query params

@kilo-code-bot
Copy link
Copy Markdown

kilo-code-bot Bot commented May 8, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Overview

Severity Count
CRITICAL 0
WARNING 0
SUGGESTION 0

Previous issue resolved: The query string collision in buildDevUrl (line 26) has been properly fixed. The function now correctly extracts the path portion and query string separately, merging them as ?existingParams&debugger=true.

Files Reviewed (2 files)
  • lib/actions/dev.js - 0 issues (fix verified)
  • test/dev.test.js - 0 issues (new tests for query string handling)

Reviewed by minimax-m2.7 · 110,792 tokens

@alexphelps alexphelps merged commit bd6412d into main May 8, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant