non-interactive flags and ai context#14
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
| const buf = await fetchBuffer(AI_CONTEXT_DOC_URL); | ||
| upstreamBody = buf.toString('utf8'); | ||
| } catch (err) { | ||
| const wrapped = new Error(`could not fetch AI context doc: ${err.message}`); |
There was a problem hiding this comment.
WARNING: Error wrapping uses UPSTREAM_FETCH_FAILED for all fetch failures, including the AI context doc fetch at line 459. If tarball/template fetching fails elsewhere (e.g., at line 724), the error code will misleadingly say "could not fetch AI context doc" instead of the actual operation that failed. Consider using distinct error codes or including the URL that failed in the error message.
| template: templateSlug, | ||
| sdk_version: (upstreamEntry && upstreamEntry.sdk_version) || null, | ||
| }; | ||
| result.writes.campaigns_json_entry = finalSlug; |
There was a problem hiding this comment.
WARNING: result.writes.campaigns_json_entry is set to finalSlug (user-provided or default slug), but when the template is looked up in the upstream registry at line 674, the key used is templateSlug (the --template flag value). These can differ when --template and --slug have different values. The campaigns.json entry is correctly keyed by finalSlug, but the upstream SDK version lookup uses templateSlug. If templateSlug differs from finalSlug, the SDK version from the wrong template could be used. Consider validating templateSlug against the manifest when provided via flag.
Code Review SummaryStatus: 2 Issues Found | Recommendation: Address before merge Overview
Incremental Review (commit f20aee3)
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (4 files)
Fix these issues in Kilo Cloud Reviewed by minimax-m2.7 · incremental review at f20aee3 Reviewed by minimax-m2.7 · 256,051 tokens |
No description provided.