initial typedoc exploring#43
Open
alexphelps wants to merge 5 commits into
Open
Conversation
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)CRITICAL
Changes Since Last Review
Other Observations (not in diff)Issues found in unchanged code that cannot receive inline comments:
Files Reviewed (13 files in diff)
Reviewed by minimax-m2.7 · incremental review Reviewed by minimax-m2.7 · 491,451 tokens |
| "QuantityConstraints", | ||
| "FomoConfig" | ||
| ], | ||
| "treatWarningsAsErrors": true, |
There was a problem hiding this comment.
CRITICAL: "skipErrorChecking": false" combined with "treatWarningsAsErrors": true will cause the docs build to fail on any warning. The false default is redundant here while the config remains dangerously strict. Either set skipErrorChecking: true or remove treatWarningsAsErrors until the codebase is fully documented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial effort to add inline documentation for enhancer classes and interfaces for documentation with typedoc.
To run docs on your local, run with
npm run docs:dev