Skip to content

Reorganize tests into unit/integration/e2e, raise coverage to 60% (supersedes #9) - #31

Merged
Mearman merged 1 commit into
mainfrom
derived/test-unit-integration-e2e-coverage-60-v2
Oct 13, 2026
Merged

Mearman merged 1 commit into
mainfrom
derived/test-unit-integration-e2e-coverage-60-v2

Conversation

@Mearman

@Mearman Mearman commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Supersedes #9. Third link in the stacked chain; based on #30.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-10-13T09:17:26.828194Z 50f3515 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

knoxsp
knoxsp previously approved these changes Sep 17, 2026
@Mearman
Mearman force-pushed the derived/test-unit-integration-e2e-coverage-60-v2 branch from 197ae4c to 6405f2d Compare September 17, 2026 08:56
@Mearman
Mearman changed the base branch from derived/untrack-pycache-files-v2 to derived/ci-self-hosted-runners-v2 September 17, 2026 08:56
@Mearman
Mearman dismissed knoxsp’s stale review September 17, 2026 08:56

The base branch was changed.

@Mearman
Mearman disabled auto-merge September 17, 2026 09:15
@Mearman
Mearman force-pushed the derived/test-unit-integration-e2e-coverage-60-v2 branch from 6405f2d to 0d0f3d4 Compare October 12, 2026 19:16
@Mearman
Mearman changed the base branch from derived/ci-self-hosted-runners-v2 to main October 12, 2026 19:16
@Mearman

Mearman commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator Author

@codex security review

@Mearman
Mearman force-pushed the derived/test-unit-integration-e2e-coverage-60-v2 branch from 0d0f3d4 to 1ca4446 Compare October 12, 2026 19:17
@Mearman

Mearman commented Oct 12, 2026

Copy link
Copy Markdown
Collaborator Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 1ca4446962

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

Moves the lazy-import regression test under e2e, adds a shared conftest, declares the three suite markers and
sorts the existing tests under them.
@Mearman
Mearman force-pushed the derived/test-unit-integration-e2e-coverage-60-v2 branch from 1ca4446 to 50f3515 Compare October 13, 2026 09:14
@Mearman

Mearman commented Oct 13, 2026

Copy link
Copy Markdown
Collaborator Author

@codex security review

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: 50f351593f

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@Mearman
Mearman merged commit 8f02277 into main Oct 13, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants