Add id_segment for unique sub-segment identity#84
Merged
NewGraphEnvironment merged 1 commit intomainfrom Apr 5, 2026
Merged
Conversation
.frs_add_id_segment() initializes id_segment from linear_feature_id. When frs_break_apply(segment_id = "id_segment") splits segments, sub-segments get new unique id_segment values while linear_feature_id is carried from the parent (FWA provenance preserved). Tested: 510 segments → 532 after breaking. All id_segment unique. Sub-segments share parent linear_feature_id correctly (e.g. one parent split into 7 sub-segments). Also adds naming conventions to CLAUDE.md (id_* prefix, col_* params, frs_noun_verb functions, long-format habitat table structure). Fixes #82 Relates to #83 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.frs_add_id_segment()— initializesid_segmentcolumn fromlinear_feature_idfrs_break_apply(segment_id = "id_segment")splits segments, sub-segments get new uniqueid_segmentvalues whilelinear_feature_idis carried from parent (FWA provenance preserved)id_segmentis the join key between streams and habitat classification tablesValidation
id_segmentvalues unique after breaking ✓linear_feature_idshared by sub-segments from same parent ✓ (e.g. one parent split into 7 sub-segments)Test plan
devtools::test()— 528 pass, 0 failFixes #82
Relates to #83
Relates to NewGraphEnvironment/sred-2025-2026#16
🤖 Generated with Claude Code