Optimize classify: 3,700x speedup via ltree enrichment#75
Merged
NewGraphEnvironment merged 2 commits intomainfrom Apr 5, 2026
Merged
Optimize classify: 3,700x speedup via ltree enrichment#75NewGraphEnvironment merged 2 commits intomainfrom
NewGraphEnvironment merged 2 commits intomainfrom
Conversation
Two changes eliminate the classify bottleneck: 1. Enrich breaks table with wscode_ltree + localcode_ltree from FWA base network (one-time join after all breaks combined). Eliminates the 4.9M row fwa_stream_networks_sp join at classify time. 2. Split NOT EXISTS OR into two separate NOT EXISTS with AND: - Same BLK: pure measure comparison (btree index) - Cross BLK: direct ltree comparison (GIST index) PG can now use indexes on both independently. Full pipeline ADMS (5 species, falls + crossings): 90s total. Classify step alone: 0.2s (was 742s with indexes, ~840s without). Fixes #72 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
32GB shared_buffers, 96GB effective_cache_size, 2GB work_mem, 8 parallel workers per gather. Add tuning.md with scaling formulas for other machines. Relates to #72 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wscode_ltree+localcode_ltreefrom FWA base network after all break sources are combinedNOT EXISTS ... ORinto two separateNOT EXISTS ... AND— PG can use indexes independentlyfwa_stream_networks_sp(4.9M rows) at classify timePerformance
The classify step dropped from dominant bottleneck to negligible. Remaining time is
frs_col_generate(gradient recompute) andfrs_classifyfor habitat attribute ranges.Test plan
devtools::test()— 528 pass, 0 failscripts/habitat/logs/Fixes #72
Relates to NewGraphEnvironment/sred-2025-2026#16
🤖 Generated with Claude Code