Repository navigation
fix(x86): preserve ENTER faults and probe final stack permissions - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENTER did not check write permission at its final stack pointer. It could incorrectly succeed on an unmapped or read-only final frame location and publish BP/SP instead of faulting.
Probe the complete operand-width span after the real frame stores and before updating either architectural register. Reuse the store permission and invalid-access repair machinery, without a data store, valid-write observation, copy-on-write allocation, or device I/O. Completed frame stores remain visible when a later access faults; fault repair and restart retain the original entry registers.
Validation: all 22 CTest suites passed with x86, ARM and AArch64 enabled. The added x86 regressions cover 48 ordered fault cases, 16 repair/stop/restart cases, 84 overlapping-copy cases, and four write-only final probes across 16/32-bit protected-mode and 16/64-bit long-mode operands. The final-probe regressions fail against the preceding library. Independent original Linux x64 instructions confirmed the required partial-store fault behavior.