Repository navigation
[X86] Preserve source SEH state ordering during nonlocal unwind - #4
Conversation
|
Hello @gmh5225 👋 Thank you for submitting a Pull Request (PR) to the LLVM Project. Since this is your first PR, here are a few useful links covering our main contribution policies and review practices.
Please reply to this message to confirm that you have read these policies, especially the LLVM AI Tool Use Policy, and that any AI tool usage has been noted in the PR description. Frequently asked questionsHow do I add reviewers? This PR will be automatically labeled, and the relevant teams will be notified. For some parts of the project, reviewers may also be added automatically. You can also add reviewers manually using the Reviewers section on this page. If you cannot use that section, it is probably because you do not have write permissions for the repository. In that case, you can request a review by tagging reviewers in a comment using What if there are no comments? If you have not received any comments on your PR after a week, you can request a review by pinging the PR with a comment such as “Ping”. The common courtesy ping rate is once a week. Please remember that you are asking for volunteer time from other developers. Are any special GitHub settings required to contribute to LLVM? We only require contributors to have a public email address associated with their GitHub commits, see this section of LLVM Developer Policy for details. If you have questions, feel free to leave a comment on this PR, or ask on LLVM Discord or LLVM Discourse. Thank you, |
A rewritten x86 SEH function can capture state 1, activate a finally at state 4, and longjmp back. The existing depth-first scope numbering can map source rows 0,1,2,3,4 to 0,3,4,1,2. MSVC local unwind compares current and saved states numerically, so the generated function stops before running the finally. Preserving enclosing links alone does not preserve this protocol.
For x86 MSVC functions carrying the registration-state rewrite attribute and complete scope identities, order rows by source state before assigning invoke/asynchronous states. Remap enclosing links and pad states together; reject duplicate identities and enclosing states that do not precede their scopes. Keep this logic in separate CodeGen files. Ordinary frontend and incomplete/unannotated graphs retain their existing numbering.
Validation: