Skip to content

Preserve pinned release assets on tag pushes - #1

Merged
gmh5225 merged 1 commit into
mainfrom
codex/protect-pinned-release-assets
Oct 10, 2026
Merged

gmh5225 merged 1 commit into
mainfrom
codex/protect-pinned-release-assets

Conversation

@gmh5225

@gmh5225 gmh5225 commented Oct 10, 2026

Copy link
Copy Markdown

Tag-triggered builds currently grant asset replacement automatically. Pushing the r4 tag rebuilt and replaced all three already-published host packages, breaking consumers that had pinned the original digests. Tag pushes now refuse an existing release and carry overwrite=false through publication; explicit manual replacement retains its existing opt-in.

The release preparation job runs eight offline checks against its actual Bash admission step. They cover existing and new tags, explicit manual replacement, immutable releases, lookup failures, version mismatches, and artifact-only dispatch. The two tag-push checks fail before this fix; all eight pass afterward. git diff --check also passes. No LLVM compilation or library behavior changes.

@gmh5225
gmh5225 merged commit 3b4c993 into main Oct 10, 2026
8 checks passed
@github-actions

Copy link
Copy Markdown

Hello @gmh5225 👋

Thank you for submitting a Pull Request (PR) to the LLVM Project. Since this is your first PR, here are a few useful links covering our main contribution policies and review practices.

  • All contributions to LLVM must follow our LLVM AI Tool Use Policy. In particular, if you used AI while working on this PR, remember to add a note to the PR description.
  • The LLVM Code-Review Policy and Practices document contains practical information about the PR process, including how patches are reviewed and accepted, and who can review a PR.
  • Our LLVM Developer Policy describes our expectations for code quality, commit summaries and contains notes on our CI system.

Please reply to this message to confirm that you have read these policies, especially the LLVM AI Tool Use Policy, and that any AI tool usage has been noted in the PR description.


Frequently asked questions

How do I add reviewers?

This PR will be automatically labeled, and the relevant teams will be notified. For some parts of the project, reviewers may also be added automatically.

You can also add reviewers manually using the Reviewers section on this page. If you cannot use that section, it is probably because you do not have write permissions for the repository. In that case, you can request a review by tagging reviewers in a comment using @ followed by their GitHub username.

What if there are no comments?

If you have not received any comments on your PR after a week, you can request a review by pinging the PR with a comment such as “Ping”. The common courtesy ping rate is once a week. Please remember that you are asking for volunteer time from other developers.

Are any special GitHub settings required to contribute to LLVM?

We only require contributors to have a public email address associated with their GitHub commits, see this section of LLVM Developer Policy for details.


If you have questions, feel free to leave a comment on this PR, or ask on LLVM Discord or LLVM Discourse.

Thank you,
The LLVM Community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants