Repository navigation
Prove correlated high-order MBA products without expansion - #1644
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
symbolic-simplifyleaves some identically zero high-order products intact and spends its work budget trying to expand them. For example,2^29*x*(x+1)*(x+2)*(x+3)vanishes modulo 2^32 for every input, even though a parity-only argument is insufficient.Add an exact residue proof in the shared symbolic core. It groups factors by their complete additive base, partitions literal offsets by successive low bits, and bounds the product's trailing zeros over every possible base value. Bounds from different groups remain valid when their bases are correlated. Once the bound covers the word width, the product can be removed without polynomial expansion. CLI simplification and the GUI worker's symbolic source action both use this path automatically.
The proof retains multiplicities, wrapped offsets and opaque nonlinear bases. Its comparisons, traversal, wide constants and storage use the existing request budgets; incomplete proofs retain the original product. No public flag, optimizer default budget, dependency or ABI changes. The expanded worker integration suite took 207 seconds locally; its CTest timeout is adjusted from 180 to 360 seconds to cover the additional compile-and-run fixtures.
Validation on macOS ARM64 Release with the pinned LLVM 23 r6 package and Z3 enabled:
Commands used for the affected build and suites:
The reusable benchmark adds
--family residue-product --count 80; local raw reports and timing harnesses remain in ignored diagnostic directories. Core qualification uses the system allocator with optional acceleration libraries, CPU/driver emulation, Python plugins, web analysis and binary-corpus/Unicorn semantic suites disabled. Those configurations and other native hosts are outside this local qualification. Full hosted platform CI is reported separately by GitHub checks.