Repository navigation
List the runtime module and execution surfaces in the capability ledger - #1507
Merged
Merged
Conversation
#1448 added the C, JSON and CLI surfaces of caller-owned module sets and persistent execution: neverd_execution_*, neverd_module_set_*, `neverd execution` and `neverd modules`. It did not list them in docs/capabilities.json. test_check_capabilities' completeness check then failed in "Verify Debug and Release target flags" on every host, so CI has skipped configure, build and test since. docs/runtime-modules.md qualifies these surfaces and names their tests, as docs/web-analysis.md does for web inspection. They therefore join the ledger's exclusions under the emulation owner. No capability is claimed for them here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The breakage.
scripts/tests/test_check_capabilities.py::RepositoryCapabilityTests::test_repository_manifest_is_honest_and_executablefails with 44 unclaimed public declarations:neverd_execution_*/neverd_module_set_*functions;neverd execution,neverd execution --modules,neverd modules,--module,--symbol.The fix.
docs/runtime-modules.mdqualifies these surfaces and names their tests, asdocs/web-analysis.mddoes for the web inspection surfaces.surface_exclusionsunder anemulationowner, with the same kind of reason as the web-analysis group.Tests
python3 -m unittest scripts.tests.test_check_capabilities: 116 tests, OK.scripts/check_docs_i18n.pyand the other manifest/doc checks of that CI step pass locally.