Repository navigation
Give the type library functions their Python signatures - #1400
Merged
Merged
Conversation
neverd_type_libraries_json, _set, _save and _load joined the C API without signatures in the Python plugin SDK, which every exported function has; the SDK's ABI inventory test failed on dev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
neverd_type_libraries_json,_set,_saveand_load(2db98a1) joined the C API without signatures in the Python plugin SDK, which every exported function needs. As a result, dev's CI failstest_abi.ABIInventoryTests.test_every_exported_c_function_has_a_python_signature, for example in the runs for #1395 and #1398.This adds the four signatures to
pluginsdk/python/neverd_plugin/abi.py, asNeverDCAPILocalTypes.hdeclares them:jsonandsetreturn owned strings.saveandloadreturn an int.Verification:
PYTHONPATH=pluginsdk/python python3 -m unittest discover -s pluginsdk/python/testsran 216 tests, all OK (116 skipped).