Repository navigation
[types] Fetch Lua and TypeScript for the render checks - #1334
Merged
Merged
Conversation
check_type_renders.py skipped Lua wherever no Lua 5.3 or later was installed, and TypeScript wherever tsc was not. The fetch script now builds Lua 5.4.9 from lua.org's sources, checked against the SHA-256 it lists, and installs TypeScript 5.9.3 from npm; the checker takes them where it finds no other.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
check_type_renders.pyskipped Lua wherever no Lua 5.3 or later was installed, and TypeScript wherevertscwas not. Neither is installed on this host, so both were skipped on every run.scripts/fetch_render_toolchains.pynow also fetches:make linux, which needs no readline), checked against the SHA-256 lua.org lists;--ignore-scripts).Both go into
toolchains.jsonasluaandtsc. The checker takes a Lua ortscit finds on PATH first, and these where it finds none; when neither is there, the skip names the script.Verification
The fetch script completes every step: Rust, i386, armv7 and win32 Python, the cross C libraries, bionic, Lua and TypeScript.
Lua and TypeScript now run instead of being skipped:
WindowsKernelX86The default fixture's 3 failures are the MinGW compile of its Windows spelling (
redefinition of 'tagLC_ID'and the CRT's locale records). [types] Keep MinGW's x87 long double and spell it exactly in exported C #1332 reported them; the next change, which takes C library types from the system's headers, addresses them.