Added advanced option to lfdRole allowing selection of individual roles#18
Open
Brixus3 wants to merge 3 commits intoNevcairiel:masterfrom
Open
Added advanced option to lfdRole allowing selection of individual roles#18Brixus3 wants to merge 3 commits intoNevcairiel:masterfrom
Brixus3 wants to merge 3 commits intoNevcairiel:masterfrom
Conversation
pilotstew
approved these changes
Nov 19, 2021
Author
|
I made some changes to the options text. All four labels should now localize as they are in blizzard's global strings. I've been trying to find a way to test this myself but when I run the workspace action curseforge skips localization due to incorrect token and/or project ID. I assume I'd have to create a new project id using my fork to test but I don't want to do that. Any chance @Nevcairiel can review this? Thanks in advance and also for maintaining this project. |
Repository owner
deleted a comment from
timetofall
Nov 9, 2022
|
Please implement this. I'd love to see character roles on their frame. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added an advanced option to the Class Role indicator allowing individual selection.
