Skip to content

Pinned polars below 2 for the database group - #227

Merged
CodyCBakerPhD merged 2 commits into
mainfrom
claude/magical-meitner-v91a45
Nov 12, 2026
Merged

CodyCBakerPhD merged 2 commits into
mainfrom
claude/magical-meitner-v91a45

Conversation

@CodyCBakerPhD

Copy link
Copy Markdown
Collaborator

BenchmarkDatabase._preprocess_environments calls Expr.replace(..., default=None), which polars 2 removed, so nwb_benchmarks generate_figures fails with ArgumentRemovedError on a fresh install.
This pins polars<2 in the database dependency group.

Original prompt

contribute anything wrong upstream

as far as polars do a pr to pin that to avoid the issue; machine ID is known and I responded to it; the figure 4b stuff dont worry


Generated by Claude Code

The figure code calls Expr.replace(default=...), which polars 2 removed,
so `nwb_benchmarks generate_figures` fails on a fresh install.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DQrzw3EzjrfYqHpgtbET2T
@CodyCBakerPhD CodyCBakerPhD self-assigned this Nov 12, 2026
@CodyCBakerPhD
CodyCBakerPhD marked this pull request as ready for review November 12, 2026 23:46
@CodyCBakerPhD

Copy link
Copy Markdown
Collaborator Author

Another case of AI being smarter than me; had no clue our usage of polars was implicitly assuming v1

@CodyCBakerPhD
CodyCBakerPhD merged commit f88603a into main Nov 12, 2026
3 checks passed
@CodyCBakerPhD
CodyCBakerPhD deleted the claude/magical-meitner-v91a45 branch November 12, 2026 23:47
CodyCBakerPhD pushed a commit that referenced this pull request Nov 12, 2026
#227 released 0.4.3 on main, so after merging main this branch carried
the same version and the version check failed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019XGZPsK77kY9cukQuY4a7R
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants