Add extra optional withdrawals to prefund EOAs#144
Open
jochem-brouwer wants to merge 2 commits into
Open
Conversation
…ng at pkey 0x1111..11 (incremented by one, 15k times)
7 tasks
Comment on lines
+1201
to
+1207
| sender_addresses_path = Path("sender_addresses.txt") | ||
| if sender_addresses_path.exists(): | ||
| sender_lines = [ | ||
| ln.strip() | ||
| for ln in sender_addresses_path.read_text(encoding="utf-8").splitlines() | ||
| if ln.strip() | ||
| ] |
Collaborator
There was a problem hiding this comment.
I am not sure if this a good idea to pre-calculate all the withdraw account in sender_addresses.txt, we could use some addr calculation package here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of gas-repricings in context of EIP-2780, this PR adds an optional file to prefund EOAs. This is part of the funding, as after funding benchmarkoor takes a snapshot and restarts clients, forcing them to read this from disk. This ensures we do not have to bloat accounts or create a new snapshot a-la-jochemnet.
NOTE: this create 15001 withdrawals in a single block which could be problematic.
Related PR on execution-specs: ethereum/execution-specs#2837