Repository navigation
Several very minor quality of life tweaks - #160
Merged
Merged
Conversation
Before this patch, the gossip loop read the message generation and the trust derivation before calling `change_sig.borrow_and_update()`. A local signed-state change updates the trust derivation and bumps the message generation as two separate steps, observed by separate tasks. If a notification landed in the window between those reads and the acknowledge, the signal was marked seen without influencing the iteration that just ran, so the update sat idle until the next periodic tick instead of re-waking the loop. This commit instead acknowledges the signal (and resets the tick) up front, before reading the derivation and generation. Any notification that arrives during the reads now leaves the signal unseen, so the next `changed()` wakes the loop immediately and convergence no longer waits on the interval.
Simple helper to print the node's IMID.
Very minor tyle tweak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.