Repository navigation
dsl: resolve self to the local imid in debug endorse input - #159
Merged
Merged
Conversation
This commit instead introduces a `self` alias in the DSL ident parser. `parse_endorsements` and `parse_constraint` now take a `self_imid`, and bare `self` resolves to it anywhere an imid is accepted (endorser, target, authz source/dest, nested constraints). Positions that do not accept imids — claim values, names — continue to reject `self`. The CLI fetches its own imid from `admin_client.debug_dump()` and threads it through; the e2e self-endorsement loop now uses `self endorses self`, exercising the alias end to end.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit introduces a
selfalias in the DSL ident parser.parse_endorsementsandparse_constraintnow take aself_imid, and bareselfresolves to it anywhere an imid is accepted (endorser, target, authz source/dest, nested constraints). Positions that do not accept imids — claim values, names — continue to rejectself. The CLI fetches its own imid fromadmin_client.debug_dump()and threads it through; the e2e self-endorsement loop now usesself endorses self, exercising the alias end to end.