Skip to content

test: fix race in the throttle cap spec #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JNK234 merged 1 commit into from
Oct 22, 2026
Merged

test: fix race in the throttle cap spec #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/test/RequestThrottleSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,10 @@ class RequestThrottleSpec extends AnyFunSuite {
}
}

eventually("the cap to be filled")(running.get() == 2)
assert(peak.get() == 2, s"only 2 may run at once, saw ${peak.get()}")
// Wait on peak, not running: a request raises running before it records
// peak, so seeing running == 2 does not mean peak has caught up yet.
eventually("the cap to be filled")(peak.get() == 2)
assert(running.get() == 2, s"only 2 may run at once, saw ${running.get()}")

gates.foreach(_.trySuccess(()))
Await.result(Future.sequence(calls), 10.seconds)
Expand Down
Loading