Skip to content

Fix compiler warnings in newer builds#35

Open
LadyCailin wants to merge 1 commit intoNerdNu:masterfrom
LadyCailin:master
Open

Fix compiler warnings in newer builds#35
LadyCailin wants to merge 1 commit intoNerdNu:masterfrom
LadyCailin:master

Conversation

@LadyCailin
Copy link
Copy Markdown
Contributor

This is a 'light touch' change, in that I didn't change most of the older syntax other than the places that will cause problems in future builds. For the most part, this manifests itself in using the new syntax for procs (proc _name() {} instead of proc(_name, ...)) quoting event names in binds, as well as removing a few other uses of bare strings here and there. These eliminate all the compiler warnings in current builds of CH, but should be backwards compatible with all builds in the past 5 years or whatever. There are a few compile errors which I didn't fix, because presumably you are still on an older build in which these work, and fixing them for modern CH will break it for older CH. However, there are only a handful of these, so upgrading in the future should be much easier now for you.

@totemo
Copy link
Copy Markdown
Member

totemo commented Sep 4, 2019

Hi LadyCailin. Thanks for the PR. Unfortunately we're using the luckperms branch for P and C at the moment and we'll be merging that once we get around to updating the lobby.

@LadyCailin
Copy link
Copy Markdown
Contributor Author

LadyCailin commented Sep 5, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants