Fix compiler warnings in newer builds#35
Open
LadyCailin wants to merge 1 commit intoNerdNu:masterfrom
Open
Conversation
Member
|
Hi LadyCailin. Thanks for the PR. Unfortunately we're using the luckperms branch for P and C at the moment and we'll be merging that once we get around to updating the lobby. |
Contributor
Author
|
Doh! Deaygo told me this after the fact 🙄
I’ll see about doing the other branch then.
… On 5 Sep 2019, at 01:39, totemo ***@***.***> wrote:
Hi LadyCailin. Thanks for the PR. Unfortunately we're using the luckperms branch for P and C at the moment and we'll be merging that once we get around to updating the lobby.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a 'light touch' change, in that I didn't change most of the older syntax other than the places that will cause problems in future builds. For the most part, this manifests itself in using the new syntax for procs (
proc _name() {}instead ofproc(_name, ...)) quoting event names in binds, as well as removing a few other uses of bare strings here and there. These eliminate all the compiler warnings in current builds of CH, but should be backwards compatible with all builds in the past 5 years or whatever. There are a few compile errors which I didn't fix, because presumably you are still on an older build in which these work, and fixing them for modern CH will break it for older CH. However, there are only a handful of these, so upgrading in the future should be much easier now for you.