Draft
Conversation
NeonDaniel
force-pushed
the
FEAT_MQResponseModel
branch
from
2b402f4 to
d49266c
Compare
NeonBohdan
reviewed
Dec 24, 2024
|
|
||
|
|
||
| class MQResponse(MQContext): | ||
| is_final: bool = Field(default=True, alias="_is_final", |
There was a problem hiding this comment.
Does it mean that every message will have this field even if not using streaming?
Member
Author
There was a problem hiding this comment.
Ideally, yes. There's not currently anything forcing any kind of MQ message validation, but my intent is that every response message will be defined in this module and will extend this MQResponse class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add MQResponse model to define parameters used for multi-part response handling
Issues
Implements responses documented in NeonGeckoCom/neon_mq_connector#101
Other Notes