Re-implement mycroft.ready event emit with service status checks#765
Merged
NeonDaniel merged 14 commits intodevfrom Sep 11, 2025
Merged
Re-implement mycroft.ready event emit with service status checks#765NeonDaniel merged 14 commits intodevfrom
mycroft.ready event emit with service status checks#765NeonDaniel merged 14 commits intodevfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactors configuration envvars to be set earlier in the service load process
Implements new logic to handle service readiness checks which support ovos-core 0.2+
Updates unit tests to cover changes to NeonSkillManager
Issues
Other Notes
Includes clean up of config envvars in test cases