Feat/validate lucide icons#21
Merged
NeonDaniel merged 3 commits intoNeonGeckoCom:mainfrom Mar 23, 2026
Merged
Conversation
…ads directly from the local npm package.
NeonDaniel
approved these changes
Mar 23, 2026
Member
NeonDaniel
left a comment
There was a problem hiding this comment.
Looks good. In the future, we can run that script to update icon names in some GHA automation so things are always up-to-date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds Lucide icon name validation to Pydantic models. When a config file specifies an
iconfield, the value is now checked against the set of valid PascalCase Lucide icon names at load time. Invalid icons produce aValidationErrorwith a clear error message._IconValidatorMixininconfig.py— a Pydantic model validator applied toFeatureConfig,ExampleCategory, andPersonaItemConfiglucide_icons.py— reads a pre-generated JSON registry of 1,861 valid icon names_lucide_icon_names.json— static registry generated from the installedlucide-reactpackagegenerate_icon_names.py— generator script that introspects the locallucide-reactNode package exports to get the ground truth PascalCase names used by the front-endIssues
Closes #6
Other Notes
lucide-reactversion on the front-end, it doesn't make sense to re-compute the static list every time we start the app. The name generation script will need to be run manually when we change the version, but a CI workflow can enforce that the committed icon list stays in sync with the installed package version.node_modulesto be installed inphd-advisor-frontend/(npm ciornpm install). It does not require network access beyond the npm registry.Made with Cursor.