Fix: added culture invariance to fix dumped obj files problems#3
Fix: added culture invariance to fix dumped obj files problems#3pulguinha1304 wants to merge 1 commit into
Conversation
|
Turning off culture settings as opposed to just writing the obj with invariant culture is not a good solution. |
|
Should we then implement a more tightly scoped solution by using invariant culture only on the thread of the application at Program.cs? From my research, that would be an equivalent alternative, just with a tighter scope. I could rerun the tests to make sure. |
|
Are you using AI? |
|
No. The first solution I submitted was based on this Github .NET documentation. The second solution that I broadly mentioned after your comment, was an alternative that I found when researching a way to apply the same setting but on a limited scope. See this .NET docs and this. I'm trying to read all docs and learn along the way to contribute to the tool, so no AI slop is being generated on my end. All that said, I'm not a seasoned developer, so any suggestions/directions are greatly appreciated. |
2 participants
As mentioned in depth on issue #2, this change aims to add a Culture Invariace to the project in order to solve problems generated by running the dumping feature of the application on systems which their region format is set to a country that uses comma as decimal separators.
This simple change aims to bring overall consistency in the results of the dumped vertex data to files when ran by users across all countries.
After this change, tests were made with CAR4 files locally with
dotnet runand also by compiling and running the executable, which delivered the intended results: valid .obj files regardless of system region format.