Skip to content

fix: add favicon.ico - #185

Merged
Ndevu12 merged 2 commits into
Ndevu12:mainfrom
deshrajvermay9517-png:fix/add-favicon-ico-165
Jun 24, 2026
Merged

fix: add favicon.ico#185
Ndevu12 merged 2 commits into
Ndevu12:mainfrom
deshrajvermay9517-png:fix/add-favicon-ico-165

Conversation

@deshrajvermay9517-png

Copy link
Copy Markdown
Contributor

This PR adds a favicon.ico file to the Django static directory to reduce repeated "/favicon.ico" 404 errors in production logs.

Changes:

  • Added "src/the_inventory/static/favicon.ico"
  • Ensures browsers can request the favicon without generating unnecessary 404 log noise

Related Issue:
Closes #165

@deshrajvermay9517-png

Copy link
Copy Markdown
Contributor Author

Hi @Ndevu12, I have updated the PR with the additional changes.

Changes made:

  • Added "src/the_inventory/static/favicon.ico"
  • Configured the favicon route so "/favicon.ico" can be served properly
  • Updated "CHANGELOG.md"

Please review when you get a chance. Thank you!

@Ndevu12 Ndevu12 added documentation Improvements or additions to documentation area:dx Developer Experience and removed documentation Improvements or additions to documentation labels Jun 23, 2026
@Ndevu12
Ndevu12 requested a review from Copilot June 23, 2026 13:02

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Ndevu12

Ndevu12 commented Jun 23, 2026

Copy link
Copy Markdown
Owner

Hi @Ndevu12, I have updated the PR with the additional changes.

Changes made:

  • Added "src/the_inventory/static/favicon.ico"
  • Configured the favicon route so "/favicon.ico" can be served properly
  • Updated "CHANGELOG.md"

Please review when you get a chance. Thank you!

Feel free to rebase with the origin/main branch

@deshrajvermay9517-png

Copy link
Copy Markdown
Contributor Author

Hi @Ndevu12, I have rebased the branch with the latest main and pushed the updated branch.

Please review when you get a chance. Thank you!

@Ndevu12

Ndevu12 commented Jun 24, 2026

Copy link
Copy Markdown
Owner

LGTM

@Ndevu12
Ndevu12 merged commit dbc8260 into Ndevu12:main Jun 24, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:dx Developer Experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add favicon.ico to reduce 404 errors in production logs

3 participants