Removed unneeded depedency#52
Open
egonw wants to merge 1 commit into
Open
Conversation
|
Hi @egonw In the meantime we also updated to httpcomponents:httpclient:jar:4.5.14. About removing the direct dependency I lean towards leaving it in the pom. Since we directly use httpclient in our code, this gives us some control on which version to use. When rdf4j removed that dependency, we needed it anyway, so for us it is not a transitive dependency but a direct one. |
Author
hi @ziroli, the needed upgrade that I think is needed is to httpclient5, not 4.5. |
Member
|
RDF4J is working on the upgrade: eclipse-rdf4j/rdf4j#5723 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was meant to implement #50 but it turns out that the direct depedency was redundant and that removing it does not give warnings with
mvn clean installand neither withmvnw -B test.However, it also does not remove the httpclient 4 depedency, as it is indirectly pulled in via RDF4j:
Eclipse RDF4j is thinking about upgrading but it does not seem to have been implemented yet: eclipse-rdf4j/rdf4j#4472