Skip to content

Removed unneeded depedency#52

Open
egonw wants to merge 1 commit into
Nanopublication:masterfrom
egonw:upgrade/httpclient5
Open

Removed unneeded depedency#52
egonw wants to merge 1 commit into
Nanopublication:masterfrom
egonw:upgrade/httpclient5

Conversation

@egonw
Copy link
Copy Markdown

@egonw egonw commented Aug 28, 2025

This PR was meant to implement #50 but it turns out that the direct depedency was redundant and that removing it does not give warnings with mvn clean install and neither with mvnw -B test.

However, it also does not remove the httpclient 4 depedency, as it is indirectly pulled in via RDF4j:

+- org.eclipse.rdf4j:rdf4j-rio-jsonld:jar:5.1.4:compile
|  +- no.hasmac:hasmac-json-ld:jar:0.9.0:compile
|  |  \- org.glassfish:jakarta.json:jar:2.0.1:compile
|  +- jakarta.json:jakarta.json-api:jar:2.0.1:compile
|  +- org.glassfish:jakarta.json:jar:module:2.0.1:compile
|  +- org.apache.httpcomponents:httpclient:jar:4.5.14:compile
|  |  \- org.apache.httpcomponents:httpcore:jar:4.4.16:compile
|  +- org.apache.httpcomponents:httpclient-cache:jar:4.5.14:compile
|  +- org.slf4j:jcl-over-slf4j:jar:1.7.36:runtime
|  \- com.fasterxml.jackson.core:jackson-core:jar:2.13.5:compile

Eclipse RDF4j is thinking about upgrading but it does not seem to have been implemented yet: eclipse-rdf4j/rdf4j#4472

@ziroli
Copy link
Copy Markdown

ziroli commented Sep 10, 2025

Hi @egonw

In the meantime we also updated to httpcomponents:httpclient:jar:4.5.14.

About removing the direct dependency I lean towards leaving it in the pom. Since we directly use httpclient in our code, this gives us some control on which version to use. When rdf4j removed that dependency, we needed it anyway, so for us it is not a transitive dependency but a direct one.

@egonw
Copy link
Copy Markdown
Author

egonw commented Sep 11, 2025

we also updated to httpcomponents:httpclient:jar:4.5.14.

hi @ziroli, the needed upgrade that I think is needed is to httpclient5, not 4.5.

@ashleycaselli
Copy link
Copy Markdown
Member

RDF4J is working on the upgrade: eclipse-rdf4j/rdf4j#5723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants