Conversation
Conflicts: src/meep.hpp src/sources.cpp
…report false positives/negatives)
Collaborator
There was a problem hiding this comment.
Why are you unconditionally defining this rather than modifying configure.ac to check for it?
Collaborator
|
(Would be good to have a Scheme/libctl interface for this too, no?) Once, this PR is in good shape, it would be good to squash the commits into a single one for merging. |
Conflicts: src/susceptibility.cpp
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose to include the band source into MEEP, as I originally advertised in April 2014. It gives more control to the source spectrum, e.g. to selectively excite a group of resonance modes, whereas other unwanted modes are efficiently suppressed.
More information can be found in the dedicated chapter on my website, http://fzu.cz/~dominecf/meep/index.html#bandsource
Please disregard some of the related commits, they were erroneous and I effectively reverted them later.
This feature still uses the automatic decision whether GSL is available or not (in which case the behavior changes to inaccurate, but similar sinc function). As a matter of fact, I am not able to improve this in the configure scripts at the moment. It should not be too confusing anyway, I believe.