Skip to content

Add ImageText block to post#961

Open
rchlfryn wants to merge 5 commits intomainfrom
add-img-text-to-post
Open

Add ImageText block to post#961
rchlfryn wants to merge 5 commits intomainfrom
add-img-text-to-post

Conversation

@rchlfryn
Copy link
Collaborator

@rchlfryn rchlfryn commented Mar 1, 2026

Description

Adds the ImageText block to posts (via the Lexical rich text editor)

Related Issues

Noticed there was no option to add to Sierra's daily flow

Key Changes

  • Added ImageText block to the Posts collection and Lexical rich text editor
  • Replaced manual background color handling with the shared BackgroundColorWrapper component

How to test

  1. In a Post's Lexical editor, add an ImageText block and verify it renders correctly
  2. Toggle image layout between left/right and verify float direction changes
  3. Verify existing ImageText blocks on Pages still render correctly

Screenshots / Demo video

Future enhancements / Questions

  • Consider making the image size configurable

@github-actions
Copy link

github-actions bot commented Mar 1, 2026

Migration Safety Check

Found 4 potential issues:

20260227_230151_add_text_wrap_to_image_text_block.ts

Warning (line 6): ALTER keyword detected - review for data loss

sql`ALTER TABLE \`home_pages_blocks_image_text\` ADD \`text_wrap\` integer DEFAULT false;`,

Warning (line 9): ALTER keyword detected - review for data loss

sql`ALTER TABLE \`_home_pages_v_blocks_image_text\` ADD \`text_wrap\` integer DEFAULT false;`,

Warning (line 12): ALTER keyword detected - review for data loss

sql`ALTER TABLE \`pages_blocks_image_text\` ADD \`text_wrap\` integer DEFAULT false;`,

Warning (line 15): ALTER keyword detected - review for data loss

sql`ALTER TABLE \`_pages_v_blocks_image_text\` ADD \`text_wrap\` integer DEFAULT false;`,

Review these patterns and add backup/restore logic if needed. See docs/migration-safety.md for guidance.

@github-actions
Copy link

github-actions bot commented Mar 1, 2026

Preview deployment: https://add-img-text-to-post.preview.avy-fx.org

@rchlfryn rchlfryn requested a review from busbyk March 2, 2026 17:34
Copy link
Collaborator

@busbyk busbyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed there was no option to add to Sierra's daily flow

Can you explain this use case a little more?

If the goal is just to have the ability for content editors to include images where the text wraps around them, I wonder if it makes more sense to allow this as an option when embedding MediaBlocks in the ContentBlock/lexical editors rather than expecting them to know they need to use the ImageText component.

The code looks good - just a UX question.

@rchlfryn
Copy link
Collaborator Author

rchlfryn commented Mar 3, 2026

Can you explain this use case a little more?

If the goal is just to have the ability for content editors to include images where the text wraps around them, I wonder if it makes more sense to allow this as an option when embedding MediaBlocks in the ContentBlock/lexical editors rather than expecting them to know they need to use the ImageText component.

I was trying to give Sierra the ability to match their old Daily flow posts
Screenshot 2026-03-03 at 09 59 20

We briefly talked about this in stand, but just to recap.. it would be nice to see what users would want as a UX experience. We don't know what makes sense to them. If we do end up adding this functionality to the content or media block, I think it will make our code more complicated, so we want to be sure that is the correct UX for users.

@rchlfryn rchlfryn requested a review from busbyk March 3, 2026 18:02
@busbyk busbyk mentioned this pull request Mar 3, 2026
4 tasks
@rchlfryn rchlfryn changed the title Add ImageText block to post & add textWrap Add ImageText block to post Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants