-
Notifications
You must be signed in to change notification settings - Fork 15
Issue 889: Add Observation Only Zones #904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wheninseattle
wants to merge
31
commits into
NWACus:main
Choose a base branch
from
wheninseattle:wn-889-add-observation-zones
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
434e5b1
data: fetch and parse alternate zones
wheninseattle b153c44
Merge alternateZones with mapLayer - outline next steps
wheninseattle 704d2d6
Add types
wheninseattle 5381a3e
Decouple mapLayer context and alt zones. Filter zones with no observa…
wheninseattle 0aac541
Add hooks to incomplete query block and remove mapLayer feature filter
wheninseattle 4a58064
WIP
wheninseattle 0daa506
Merge branch 'main' into wn-889-add-observation-zones
wheninseattle 0d7f3f2
Improve types
wheninseattle 4021e1a
Add prefetching
wheninseattle 21f132e
Break out functions and add unit tests
wheninseattle f276c99
Change KML typing to Zod
wheninseattle 94b5e6e
Merge branch 'main' into wn-889-add-observation-zones
wheninseattle cfa8ebd
Improve type safety and break out functions
wheninseattle 726d1ba
Add tests for KML parsing
wheninseattle bd6ad1b
Fix dependancies
wheninseattle 6ac7afb
Pick up code review comments
wheninseattle 84358de
Implement prefetching
wheninseattle 8e15125
Address comments
wheninseattle f1575de
Fix package issues
wheninseattle 8a4c0b2
making ci happy
yuliadub 23c644d
get changes from avy main
yuliadub 67b712b
make prettier happy
yuliadub 8033735
add custom zone name to obs detail view header
yuliadub 02b7643
adjust xml parsing package and fix yarn lock
yuliadub 0acef2c
revert yarn.lock changes
yuliadub 450bd48
remove random yarn files
yuliadub dabca18
adjust yarn.lock and fix package.json
yuliadub 0dff730
fix tests
yuliadub ed223ca
fix zod errors
yuliadub 85dbe13
merge main changes in
yuliadub 92cbfdd
add fast-xml-parser back
yuliadub File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rustynwac let's pin down the UX we want for the two sets of zones in the filter modal with an eye to what the websites are doing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rustynwac @stevekuznetsov did we decide how we want to represent the zones?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rustynwac let's sync on this