fix(ipc): drop stale ring on failed re-registration - #261
Open
WilliamK112 wants to merge 1 commit into
Open
Conversation
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
WilliamK112
force-pushed
the
codex/fix-ipc-reregister-ring-failure
branch
from
July 2, 2026 02:59
cf1dfb1 to
f64d414
Compare
WilliamK112
marked this pull request as ready for review
July 2, 2026 02:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_ring_registryFixes #209
Validation
NVIDIA/xr-ai@ec4169aa3e3c8a57f1d7f59d3e2d97ad9163a8bb209,_ring_registry, andfailed re-registrationonly return this PRuv run pytest -v test_participant_events.py::test_connector_reregistration_open_failure_drops_stale_ring(fromtests/) - 1 passeduv run python -m py_compile ..\server-runtime\xr_media_hub\ipc\_hub.py test_participant_events.py(fromtests/)uv tool run --from ruff==0.15.16 ruff check server-runtime\xr_media_hub\ipc\_hub.py tests\test_participant_events.pygit diff --check origin/main..HEADLocal environment note: full
uv run pytest -v test_participant_events.pyon this Windows shell reports the new #209 regression test passing, while the existing four fixture-backed tests error before their test bodies because this local libzmq build does not support theipc://...transport used byconftest.py.