Skip to content

Pin LiveKit server Docker image - #258

Open
WilliamK112 wants to merge 2 commits into
NVIDIA:mainfrom
WilliamK112:fix/pin-livekit-image
Open

Pin LiveKit server Docker image#258
WilliamK112 wants to merge 2 commits into
NVIDIA:mainfrom
WilliamK112:fix/pin-livekit-image

Conversation

@WilliamK112

@WilliamK112 WilliamK112 commented Jun 18, 2026

Copy link
Copy Markdown

Summary

  • Pin the embedded LiveKit server Docker image to livekit/livekit-server:v1.13.1 instead of latest.
  • Reuse the runtime image constant in the LiveKit integration test pre-pull step so tests exercise the same image reference.

Fixes #27.

Testing

  • uv run python -m py_compile server-runtime\xr_media_hub\transport\livekit\_docker.py tests\test_integration_livekit.py
  • uv tool run --from ruff==0.15.16 ruff check server-runtime\xr_media_hub\transport\livekit\_docker.py tests\test_integration_livekit.py
  • git diff --check origin/main..HEAD
  • Confirmed no livekit/livekit-server:latest references remain under server-runtime or tests
  • uv run pytest -rs -v test_integration_livekit.py from the tests project collected the module but skipped it because Docker is not on PATH in this local Windows environment

Rebased onto current origin/main (ec4169aa) and force-pushed with lease.

@nvddr

nvddr commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

The CI failure here is unrelated to this PR's changes. Root cause: pipecat-ai>=0.0.46 in the dependency tree allows resolving to v0.0.79, which transitively pulls numba v0.53.1llvmlite v0.36.0, which only supports Python <3.10. Main CI has been passing because it hits a warm uv cache with a newer resolution; fork PRs build without cache access, get a fresh resolve, and land on the old version.

PR #260 fixes the underlying floor (pipecat-ai>=0.0.46 → >=1.0 along with a few other stale floors). Once that lands, this PR should pass CI.

@nvddr
nvddr enabled auto-merge (squash) June 24, 2026 18:33
@nvddr
nvddr self-requested a review June 24, 2026 18:33
auto-merge was automatically disabled July 1, 2026 00:01

Head branch was pushed to by a user without write access

@WilliamK112
WilliamK112 force-pushed the fix/pin-livekit-image branch from 99fc83d to 52719c9 Compare July 1, 2026 00:01
Signed-off-by: WilliamK112 <164879897+WilliamK112@users.noreply.github.com>
@WilliamK112
WilliamK112 force-pushed the fix/pin-livekit-image branch from 52719c9 to 7e9024c Compare July 2, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nit: use a deterministic version

2 participants