Skip to content

nit: Rename rmsnorm to rms_norm - #1384

Merged
akihironitta merged 1 commit into
mainfrom
aki/rename-rms
Nov 18, 2026
Merged

akihironitta merged 1 commit into
mainfrom
aki/rename-rms

Conversation

@akihironitta

Copy link
Copy Markdown
Member

No description provided.

@copy-pr-bot

copy-pr-bot Bot commented Nov 18, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@akihironitta
akihironitta enabled auto-merge (squash) November 18, 2026 23:50
@codecov

codecov Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.59%. Comparing base (c4e6485) to head (7b1258d).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
sdm/_kernels/triton/rms_norm_cast.py 0.00% 3 Missing ⚠️
sdm/_kernels/rms_norm_cast.py 60.00% 2 Missing ⚠️
sdm/nn/rms_norm.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1384   +/-   ##
=======================================
  Coverage   84.58%   84.59%           
=======================================
  Files         266      266           
  Lines       14185    14185           
=======================================
+ Hits        11999    12000    +1     
+ Misses       2186     2185    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@akihironitta
akihironitta merged commit 720cc74 into main Nov 18, 2026
5 of 7 checks passed
@akihironitta
akihironitta deleted the aki/rename-rms branch November 18, 2026 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants