Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
332dd65
Replace recorded fixture outputs with behavioral assertions
adi-kumo Nov 10, 2026
36103e5
Prune unused conversion recordings and report unavailable database tests
adi-kumo Nov 10, 2026
40cb750
Normalize cleanup tracker line endings
adi-kumo Nov 10, 2026
8d15fea
Replace schema pickle and numeric text snapshots with assertions
adi-kumo Nov 10, 2026
a6eb019
Check live wire construction with source-based assertions
adi-kumo Nov 10, 2026
b220f2b
Remove unused native baselines and record retained test inputs
adi-kumo Nov 10, 2026
4cfd58c
Replace request state and SQL snapshots with behavioral checks
adi-kumo Nov 10, 2026
9cb6c0d
Replace encoding snapshots and document interoperability fixtures
adi-kumo Nov 10, 2026
7896714
Replace exact key snapshots with source-based PostgreSQL assertions
adi-kumo Nov 10, 2026
497166e
Replace remaining PostgreSQL conversion recordings with assertions
adi-kumo Nov 10, 2026
dce3619
Derive neighbor sampling expectations from source rows
adi-kumo Nov 10, 2026
402efaa
Replace temporal candidate recordings with direct contract assertions
adi-kumo Nov 10, 2026
4d5129d
Replace historical pickle output snapshots with behavior assertions
adi-kumo Nov 10, 2026
c526deb
Finish fixture replacements with source-based provider assertions
adi-kumo Nov 10, 2026
82444ab
Clarify maintained wire checks and SQL test helpers
adi-kumo Nov 10, 2026
5cd4ec5
Remove unused fixture compression and retired recording helpers
adi-kumo Nov 10, 2026
93714c9
Record completed fixture tooling cleanup and retained gates
adi-kumo Nov 10, 2026
130df04
Fix integrated formatting, type ledger and parser test boundaries
adi-kumo Nov 10, 2026
7d21572
Remove unused explanation fixture reader caught by full Clippy
adi-kumo Nov 10, 2026
c8293fd
Fix query factory identity validation after fixture reduction
adi-kumo Nov 10, 2026
0f27447
Reconcile required Rust refusal test and integrated validation evidence
adi-kumo Nov 10, 2026
39afcf7
Remove temporary fixture cleanup audit records
adi-kumo Nov 10, 2026
ac22587
Reanchor fixture contract decision to merged release baseline
adi-kumo Nov 10, 2026
0d2db95
Strengthen independent assertions for fixture cleanup gaps
adi-kumo Nov 10, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
44 changes: 2 additions & 42 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -889,7 +889,7 @@ jobs:
--native-sha256 "$(python -I -c 'import hashlib, pathlib, sdm_client._native as n; print(hashlib.sha256(pathlib.Path(n.__file__).read_bytes()).hexdigest())')" \
gate-observations/python-core.jsonl || status=$?
exit $status
# Preserve observations for SQL golden checks.
# Preserve case observations for failure diagnosis.
- if: ${{ !cancelled() }}
uses: actions/upload-artifact@cf430e030ddbb5b0abf93d22962f4752f3646cd9 # v7.0.2
with:
Expand Down Expand Up @@ -975,7 +975,7 @@ jobs:
- *contract-gate

# Run the native client on each database and supported dependency stack.
# The provider's executed SQL observations also feed the golden checks.
# Execute the same case contracts against SQLite's provider.
contract-python-pandas3-sqlite:
if: ${{ !(github.event_name == 'workflow_dispatch' && inputs.pql_runtime_only) }}
name: contract-python (pandas3, sqlite)
Expand Down Expand Up @@ -1154,46 +1154,6 @@ jobs:
- *contract-postgres-vectors
- *contract-database

# Check the SQL actually executed by the Python providers against the native goldens.
l4-goldens:
name: l4-goldens (${{ matrix.database }})
runs-on: ubuntu-latest
timeout-minutes: 30
needs:
- configuration
- contract-python-pandas3
- contract-python-pandas3-sqlite
- contract-python-pandas3-postgres
if: ${{ !(github.event_name == 'workflow_dispatch' && inputs.pql_runtime_only) && !cancelled() }}
strategy:
fail-fast: false
matrix:
include:
- database: duckdb
observations: observations-python-core
- database: sqlite
observations: observations-python-core-sqlite
- database: postgres
observations: observations-python-core-postgres
defaults:
run:
working-directory: rust
steps:
- uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1
- run: rustup toolchain install
- uses: Swatinem/rust-cache@6323deb102c322ba6fcbdcafc7e3dddab59af2b6 # v2.9.2
with:
workspaces: rust
save-if: ${{ env.SAVE_CACHES == 'true' }}
- uses: actions/download-artifact@9000827ccba6bdab643e8b6fd33ac0654aef8333 # v8.0.2
with:
name: ${{ matrix.observations }}
path: l4
- name: The goldens, and the run held to them
env:
SDM_L4_OBSERVATIONS: ${{ github.workspace }}/l4/python-core.jsonl
run: cargo test -p sdm-data --locked --test ${{ matrix.database }}_goldens

l5-conversion:
if: ${{ !(github.event_name == 'workflow_dispatch' && inputs.pql_runtime_only) }}
name: l5-conversion (${{ matrix.cell }})
Expand Down
3 changes: 2 additions & 1 deletion AGENTS.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ Regenerate these; never edit them:
- `packages/structured-data-models-client/THIRD-PARTY-NOTICES-RUST.txt` --
regenerate with `python scripts/rust_core/rust_notices.py --write` and verify with `--check`.
This covers dependencies in the supported native wheel targets; do not edit its entries by hand.
- `tests/golden/` -- the exported surface and the recorded wire payloads.
- `tests/golden/` -- the exported public API surface.
Wire behavior uses independent assertions in `scripts/check_wire_behavior.py`, not generated snapshots.

## Gates that fail on prose

Expand Down
13 changes: 6 additions & 7 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ The Java library targets Java 17; the local validation environment uses JDK 21.
The fixture checks use `JAVA_HOME/bin/javac` and `JAVA_HOME/bin/javap`, falling back to PATH when unset.

`tests/` at the root is the cross-package suite: that the three distributions
agree on a version and a licence, that the recorded public surface and wire
payloads still match, and that the claims the configuration files make about
themselves are true.
agree on a version and a licence, that the public API remains compatible and wire
behavior satisfies independent assertions, and that repository configuration
claims are true.

Lint and format with `ruff`. Type-check with `mypy`. Both are blocking in CI,
over all maintained packages:
Expand All @@ -91,13 +91,12 @@ Two more gates run in CI and are quick to run first:
.venv/bin/python scripts/rust_core/rust_notices.py --check
```

Changing anything a caller can observe, such as an exported name, signature,
or wire request shape, requires recording a new snapshot in the same commit.
This makes the change visible in review:
Changing an exported name or signature requires updating the public API inventory in the same commit.
Changes to wire behavior require updating the independent behavioral assertions and checking the pinned model schema.

```bash
.venv/bin/python scripts/snapshot_public_api.py --write
.venv/bin/python scripts/snapshot_wire_payloads.py --write
.venv/bin/python scripts/check_wire_behavior.py
```

## Native memory checks
Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,8 @@ The compatibility ledger in `tests/compatibility/manifest.json` records supporte
- `packages/<package>/tests/`: each package's tests; `packages/structured-data-models-client/tests_test_ops/` needs a core built with test-only operations.
- `rust/crates/<crate>/tests/` and `rust/bindings/sdm-py/tests/`: the Rust and binding tests.
- `rust/testdata/`: shared Rust test data, including a vendored time zone database.
- `tests/golden/public_api.json` and `tests/golden/wire_payloads.json`: snapshots of the public API and the wire payloads.
- `tests/golden/public_api.json`: the public API inventory.
- `scripts/check_wire_behavior.py`: canonical wire journeys checked with independent behavioral assertions.
- `tests/test_release_contract.py`, `tests/test_skills.py`, `tests/test_native_wheel.py`, `tests/test_wheel_smoke.py`, `tests/test_rust_binding_edges.py`, `tests/test_rust_contract.py`: release, skills, native build and installed-wheel checks.
- `qa/`: manual probes against live endpoints and warehouses.

Expand Down
Loading