Skip to content

Say relational explanations need NIM 1.2 - #92

Merged
adi-kumo merged 1 commit into
v2-candidatefrom
relational-notebook-explain-version
Nov 10, 2026
Merged

adi-kumo merged 1 commit into
v2-candidatefrom
relational-notebook-explain-version

Conversation

@Manushpm8

Copy link
Copy Markdown
Collaborator

The Kumo Relational notebook says explanations need NIM version 1.1+. Kumo Relational NIM 1.1.0 refuses explanation, and 1.2.0 is the first release that serves it, so the line now says 1.2+.

The Kumo Tabular notebook's 1.1+ is already right: Kumo Tabular NIM 1.1.0 serves explanations.

🤖 Generated with Claude Code

@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown

Explain Change →

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The Example 5 text in the Databricks quickstart notebook now states that explanations require NIM version 1.2 or later. The documented minimum client version remains 1.1.0.

Changes: Example 5 documentation

Layer / File(s) Summary
NIM version requirement text
examples/databricks/kumo_relational_quickstart.ipynb
The documented minimum NIM version for explanations changes from 1.1 to 1.2. The client minimum stays 1.1.0.

Possibly related PRs

Change: Other

Merge Risk: Minimal · previous review 5b0a6

The quickstart now specifies NIM 1.2+ for relational explanations. The minimum was not independently verified, but no merge-blocking issue was established.

Architecture risk: Low · up to 5b0a6

The change affects 1 system.

Changed systems: examples

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — examples (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in examples/databricks/kumo_relational_quickstart.ipynb: The documented minimum NIM version for explanations changes from 1.1 to 1.2; the client minimum remains 1.1.0.
Pre-merge checks: Passed 5

Check name Status Explanation
Title check Passed The title "Say relational explanations need NIM 1.2" matches the single change in the PR. The Kumo Relational notebook's Example 5 now states that explanations need NIM 1.2 or later, replacing 1.1. Th…
Description check Passed The description states that the Kumo Relational notebook's explanation requirement changes from NIM 1.1+ to 1.2+. It gives the reason: Kumo Relational NIM 1.1.0 rejects the explanation parameter, and …
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "Say relational explanations need NIM 1.2" matches the single change in the PR. The Kumo Relational notebook's Example 5 now states that explanations need NIM 1.2 or later, replacing 1.1. The title is short, specific, and states the main change.

Full details: Description check

Explanation

The description states that the Kumo Relational notebook's explanation requirement changes from NIM 1.1+ to 1.2+. It gives the reason: Kumo Relational NIM 1.1.0 rejects the explanation parameter, and 1.2.0 is the first release that serves it. It also notes that the Kumo Tabular notebook's 1.1+ requirement stays unchanged. This directly describes the changeset.

Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 0f95e84 and 5b0a67e.

Files selected for processing: 1

  • examples/databricks/kumo_relational_quickstart.ipynb

Included review availability: This review used your included allowance. Your plan provides up to 12 included reviews per hour; 11 remain after this review.

coderabbitai[bot]
coderabbitai Bot previously approved these changes Nov 9, 2026
adi-kumo
adi-kumo previously approved these changes Nov 10, 2026
JGagacheva
JGagacheva previously approved these changes Nov 10, 2026
@adi-kumo
adi-kumo dismissed stale reviews from JGagacheva, coderabbitai[bot], and themself via 75c7c09 November 10, 2026 22:20
@adi-kumo
adi-kumo force-pushed the relational-notebook-explain-version branch from 5b0a67e to 75c7c09 Compare November 10, 2026 22:20
@adi-kumo
adi-kumo changed the base branch from main to v2-candidate November 10, 2026 22:20
Kumo Relational NIM 1.1.0 refuses explanations; 1.2.0 is the first
release that serves them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Manush Murali <manushm@nvidia.com>
@adi-kumo
adi-kumo force-pushed the relational-notebook-explain-version branch from 75c7c09 to ae8a3a0 Compare November 10, 2026 22:29
@adi-kumo
adi-kumo merged commit 357bd7e into v2-candidate Nov 10, 2026
18 checks passed
@adi-kumo
adi-kumo deleted the relational-notebook-explain-version branch November 10, 2026 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants