Skip to content

Keep third-party JARs out of CI downloads and give natives their notices - #108

Merged
Manushpm8 merged 1 commit into
v2-candidatefrom
v2-artifact-notices
Nov 13, 2026
Merged

Manushpm8 merged 1 commit into
v2-candidatefrom
v2-artifact-notices

Conversation

@Manushpm8

Copy link
Copy Markdown
Collaborator

For OSRB 7053842 comment 6.

  • The java-jar artifact no longer carries java/target/lib or java/target/jdbc (83 third-party JARs, 22 with no licence text). It carries java-dependencies.tsv: path, SHA-256 and Maven Central URL for each. The java-load, java and java-db jobs fetch and verify them with java/jar-load/FetchDependencies.java.
  • Each java-native-* and java-test-ops-native artifact now includes LICENSE, NOTICE and THIRD-PARTY-NOTICES-RUST.txt. That file covers the Rust crates and the embedded IANA Time Zone Database.

Checked locally: the list's 83 JARs fetched from Maven Central are byte-identical to the Maven build's copies, and a wrong digest fails the fetch. Two new tests fail on the old workflow and pass on this one.

🤖 Generated with Claude Code

The java-jar CI artifact carried 83 third-party JARs and JDBC drivers, 22
of them with no licence text inside. It now carries a list of them with
SHA-256 digests and Maven Central URLs, and each job that needs them
fetches and verifies them with java/jar-load/FetchDependencies.java.

Every downloadable JNI native library now ships beside LICENSE, NOTICE
and THIRD-PARTY-NOTICES-RUST.txt, which covers the Rust crates and the
embedded IANA Time Zone Database.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Manush Murali <manushm@nvidia.com>
@coderabbitai

coderabbitai Bot commented Nov 13, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@Manushpm8
Manushpm8 merged commit 5b1eaa2 into v2-candidate Nov 13, 2026
84 checks passed
@Manushpm8
Manushpm8 deleted the v2-artifact-notices branch November 13, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant