Repository navigation
Keep third-party JARs out of CI downloads and give natives their notices - #108
Merged
Merged
Conversation
The java-jar CI artifact carried 83 third-party JARs and JDBC drivers, 22 of them with no licence text inside. It now carries a list of them with SHA-256 digests and Maven Central URLs, and each job that needs them fetches and verifies them with java/jar-load/FetchDependencies.java. Every downloadable JNI native library now ships beside LICENSE, NOTICE and THIRD-PARTY-NOTICES-RUST.txt, which covers the Rust crates and the embedded IANA Time Zone Database. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Manush Murali <manushm@nvidia.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For OSRB 7053842 comment 6.
java/target/liborjava/target/jdbc(83 third-party JARs, 22 with no licence text). It carriesjava-dependencies.tsv: path, SHA-256 and Maven Central URL for each. The java-load, java and java-db jobs fetch and verify them withjava/jar-load/FetchDependencies.java.java-native-*andjava-test-ops-nativeartifact now includes LICENSE, NOTICE and THIRD-PARTY-NOTICES-RUST.txt. That file covers the Rust crates and the embedded IANA Time Zone Database.Checked locally: the list's 83 JARs fetched from Maven Central are byte-identical to the Maven build's copies, and a wrong digest fails the fetch. Two new tests fail on the old workflow and pass on this one.
🤖 Generated with Claude Code