Skip to content

Attribute the tz database, expire unreleased binaries, disclose psycopg - #104

Merged
Manushpm8 merged 3 commits into
v2-candidatefrom
osrb-notices-fixes
Nov 12, 2026
Merged

Manushpm8 merged 3 commits into
v2-candidatefrom
osrb-notices-fixes

Conversation

@Manushpm8

Copy link
Copy Markdown
Collaborator

Problem

The client wheel embeds the IANA Time Zone Database through the jiff-tzdb crate.
The notices listed that crate under its own licence but did not name the database.

CI kept the JAR and the JNI libraries for 90 days.
Anyone can download them from this public repository.
The Java library is not released.

The postgres and lakebase extras install psycopg.
It is LGPL-3.0-only and no doc said so.

Change

rust_notices.py reads the embedded tzdata release from jiff-tzdb's own source.
It is 2026e today.
The notices now quote the LICENSE from that tzdata release word for word.
The script stops if the release cannot be read.
It also stops when the release changes, so the new LICENSE gets read again.
Both NOTICE files point to the new section.

The JAR, the JNI libraries and the test-ops builds are now kept for one day.
The shipped native wheels keep the default.
publish.yml and the parity workflows download them from a CI run on main that can be days old.
The wheel-smoke uploads hold only reports, so they are unchanged.

The README and the installation page now say which extras install psycopg.
They give the licence and the version range.
They say the user's installer resolves it and our wheels do not bundle it.

Validation

rust_notices.py --check passes.
The quoted LICENSE matches the file in tzdata2026e.tar.gz byte for byte.
New tests cover the release parsing and the retention settings.
Both fail on the base branch.

🤖 Generated with Claude Code

The client's native module embeds the IANA Time Zone Database through
jiff-tzdb. rust_notices.py now reads the embedded release from the crate
and quotes the tz project's LICENSE. It stops when the release changes.

CI keeps the JAR, the JNI libraries and the test-ops builds for one day.
The shipped native wheels keep the default because publish.yml and the
parity workflows download them later.

The install docs say the postgres and lakebase extras install
LGPL-3.0-only psycopg, which our wheels do not bundle.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Manush Murali <manushm@nvidia.com>
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Manushpm8 and others added 2 commits November 12, 2026 11:49
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Manush Murali <manushm@nvidia.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Manush Murali <manushm@nvidia.com>
@Manushpm8
Manushpm8 merged commit 494a109 into v2-candidate Nov 12, 2026
80 checks passed
@Manushpm8
Manushpm8 deleted the osrb-notices-fixes branch November 12, 2026 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant