Repository navigation
Attribute the tz database, expire unreleased binaries, disclose psycopg - #104
Merged
Merged
Conversation
The client's native module embeds the IANA Time Zone Database through jiff-tzdb. rust_notices.py now reads the embedded release from the crate and quotes the tz project's LICENSE. It stops when the release changes. CI keeps the JAR, the JNI libraries and the test-ops builds for one day. The shipped native wheels keep the default because publish.yml and the parity workflows download them later. The install docs say the postgres and lakebase extras install LGPL-3.0-only psycopg, which our wheels do not bundle. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Manush Murali <manushm@nvidia.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Manush Murali <manushm@nvidia.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Manush Murali <manushm@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The client wheel embeds the IANA Time Zone Database through the
jiff-tzdbcrate.The notices listed that crate under its own licence but did not name the database.
CI kept the JAR and the JNI libraries for 90 days.
Anyone can download them from this public repository.
The Java library is not released.
The
postgresandlakebaseextras install psycopg.It is LGPL-3.0-only and no doc said so.
Change
rust_notices.pyreads the embedded tzdata release fromjiff-tzdb's own source.It is 2026e today.
The notices now quote the LICENSE from that tzdata release word for word.
The script stops if the release cannot be read.
It also stops when the release changes, so the new LICENSE gets read again.
Both NOTICE files point to the new section.
The JAR, the JNI libraries and the test-ops builds are now kept for one day.
The shipped native wheels keep the default.
publish.ymland the parity workflows download them from a CI run onmainthat can be days old.The wheel-smoke uploads hold only reports, so they are unchanged.
The README and the installation page now say which extras install psycopg.
They give the licence and the version range.
They say the user's installer resolves it and our wheels do not bundle it.
Validation
rust_notices.py --checkpasses.The quoted LICENSE matches the file in
tzdata2026e.tar.gzbyte for byte.New tests cover the release parsing and the retention settings.
Both fail on the base branch.
🤖 Generated with Claude Code